[GitHub] [tomcat] gmshake commented on a diff in pull request #501: Support max http request header size and max http header size configuration separation

[GitBox]

gmshake commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r846991658


##########
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##########
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
     public void setMaxHttpHeaderSize(int valueI) { maxHttpHeaderSize = valueI; 
}
 
 
+    /**
+     * Maximum size of the HTTP request message header.
+     */
+    private int maxHttpRequestHeaderSize = -1;

Review Comment:
   After the change, `maxHttpHeaderSize` becomes default maximum size of the 
HTTP message header for both request and response.
   
   If we no longer have consumer of `getMaxHttpHeaderSize()`, then I'd suggest 
to remove `maxHttpHeaderSize`, and change `setMaxHttpHeaderSize()` like this 
   
   ```java
   @Deprecated
   public void setMaxHttpHeaderSize(int valueI) {
       maxHttpRequestHeaderSize = valueI;
       maxHttpResponseHeaderSize = valueI;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org