On 24/05/2022 18:35, Christopher Schultz wrote:

<snip/>

diff --git a/java/org/apache/tomcat/util/net/AprEndpoint.java b/java/org/apache/tomcat/util/net/AprEndpoint.java
index c02e90fc09..20d10efa11 100644
--- a/java/org/apache/tomcat/util/net/AprEndpoint.java
+++ b/java/org/apache/tomcat/util/net/AprEndpoint.java
@@ -2813,6 +2813,13 @@ public class AprEndpoint extends AbstractEndpoint<Long,Long> implements SNICallB
                  return inline;
              }
+            @Override
+            protected boolean hasOutboundRemaining() {
+                // NIO2 never has remaining outbound data when the completion
+                // handler is called
+                return false;
+            }

s/NIO2/APR/?

Yes.

Should this just be the default implementation instead of an abstract superclass method and two separate -nothing implementations?

I think so. It is less code which is usually how I think about this sort of thing. I'll fix that before any back-port (assuming the fix is good).

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to