aooohan opened a new pull request, #30: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30
See #29 The problem is that common-compression has CRC checks when the closeArchiveEntry method is executed, when the method of the Entry is not DEFLATED and the SeekableByteChannel is not used. However, because we have some information modification at the time of Converter, the CRC value calculated after the modification must not be equal to the value of the CRC in the original Entry. The original Entry information is retained. https://github.com/apache/tomcat-jakartaee-migration/blob/34d7c72aa0eea3d403b287b10e92cdcead0676c7/src/main/java/org/apache/tomcat/jakartaee/Migration.java#L319-L329 There is another way to recalculate the CRC, but I don't feel it makes much sense and there is a performance overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
