[tomcat] branch main updated: Log a warning rather than throw for an unrecognised action type

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new 3e19abcd5d Log a warning rather than throw for an unrecognised action 
type
3e19abcd5d is described below

commit 3e19abcd5defa3ef49c02941a4c5295b4ab0d258
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Aug 22 14:02:51 2022 +0100

    Log a warning rather than throw for an unrecognised action type
    
    This will facilitate future additions of new functionality.
---
 java/org/apache/catalina/ha/session/DeltaRequest.java |  2 +-
 webapps/docs/changelog.xml                            | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/catalina/ha/session/DeltaRequest.java 
b/java/org/apache/catalina/ha/session/DeltaRequest.java
index c691e6d1f9..4a5c65792f 100644
--- a/java/org/apache/catalina/ha/session/DeltaRequest.java
+++ b/java/org/apache/catalina/ha/session/DeltaRequest.java
@@ -218,7 +218,7 @@ public class DeltaRequest implements Externalizable {
                     }
                     break;
                 default:
-                    throw new 
IllegalArgumentException(sm.getString("deltaRequest.invalidAttributeInfoType", 
info));
+                    
log.warn(sm.getString("deltaRequest.invalidAttributeInfoType", info));
             }//switch
         }//for
         session.endAccess();
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index ae54f10053..35de617224 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -187,6 +187,16 @@
       </fix>
     </changelog>
   </subsection>
+  <subsection name="Cluster">
+    <changelog>
+      <fix>
+        To aid future additions of new functionality, rather than throw an
+        <code>IllegalArgumentException</code> if a <code>DeltaRequest</code> is
+        passed an unrecognised action type, a warning message will now be
+        logged. (markt)
+      </fix>
+    </changelog>
+  </subsection>
   <subsection name="Other">
     <changelog>
       <fix>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org