> 2022年9月15日 15:43,Mark Thomas <ma...@apache.org> 写道: > > > On 15/09/2022 06:44, Han Li wrote: >>> 2022年9月15日 04:06,Rémy Maucherat <r...@apache.org> 写道: >>> >>> On Wed, Sep 14, 2022 at 6:43 PM Han Li <li...@apache.org> wrote: >>>> >>>> Hi all, >>>> >>>> I am very sorry, I made a fatal mistake when fixing >>>> tomcat-jakartaee-migration #29 issue, which led to #34 issue. >>> >>> Well, when you do things, you're more likely to break things. So no >>> need to apologize. > > +1 > > We all make mistakes. One of the hardest things I had to get use to with open > source was messing up in public. I was mortified the first time I did it. > These days, I just fix whatever I broke and move on to the next task. > > One of the reasons for stream-lining the release process is so that we can > easily restart a release if we need to.
: ) Thanks Mark. I feel more confident to continue doing what I am interested. Han > >> : ) Thanks. >>> >>>> I have re-fixed this issue with this solution: >>>> https://github.com/aooohan/tomcat-jakartaee-migration/blob/e07f9cb21b36fe44ef31cc97e39e2c1657a94424/src/main/java/org/apache/tomcat/jakartaee/Migration.java#L226-L239 >>>> >>>> <https://github.com/aooohan/tomcat-jakartaee-migration/blob/e07f9cb21b36fe44ef31cc97e39e2c1657a94424/src/main/java/org/apache/tomcat/jakartaee/Migration.java#L226-L239> >>>> (I 'll continue optimising code tomorrow, it's late and I'm sleepy.) >>>> >>>> I will retest it tomorrow to make sure the problem is really fixed. >>>> >>>> But I don't know if this will affect the release tasks , like 10.1.x or >>>> other version. >>>> >>>> How will we handle this situation, possibly by continuing to release >>>> tomcat-jakartaee-migration 1.0.4? >>> >>> With a regression, a 1.0.4 is needed, then start over the 10.1 and >>> 10.0 release process. >> I have fixed it. > > I'll start the 1.0.4 release now and cancel the 10.1.x and 10.0.x releases. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > <mailto:dev-unsubscr...@tomcat.apache.org> > For additional commands, e-mail: dev-h...@tomcat.apache.org > <mailto:dev-h...@tomcat.apache.org>