This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new 2492ea2d60 Fix missing attributes
2492ea2d60 is described below

commit 2492ea2d60a890da1bd8a6b33ff7e1924bd70c29
Author: remm <r...@apache.org>
AuthorDate: Thu Sep 22 22:56:19 2022 +0200

    Fix missing attributes
    
    The code is very confusing, but the main attribute map can contain
    either the get or set method as the value, so it must not be used. This
    should probably be refactored some more ...
---
 .../util/modeler/modules/MbeansDescriptorsIntrospectionSource.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsIntrospectionSource.java
 
b/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsIntrospectionSource.java
index 05f393d023..ffb0937066 100644
--- 
a/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsIntrospectionSource.java
+++ 
b/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsIntrospectionSource.java
@@ -311,7 +311,7 @@ public class MbeansDescriptorsIntrospectionSource extends 
ModelerSource
                 String name = attEntry.getKey();
                 AttributeInfo ai = new AttributeInfo();
                 ai.setName(name);
-                Method gm = attEntry.getValue();
+                Method gm = getAttMap.get(name);
                 if (gm != null) {
                     ai.setGetMethod(gm.getName());
                     Class<?> t = gm.getReturnType();


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to