Basically it seems a few "accessor" (access log element) are only in extended flavor and not the abstract one, for example servletContext.getAttribute accessor. The issue is then that abstract access log valve was created to enable to extend and forward the access log to anything else than the built-in file writer (a custom logger for ex). Now, with these differences you don't get this abstraction and either need to reimplement the pattern parsing or override a lot of the extended valve since it is quite bound to the writer (open for ex). So I'm looking to unify both worlds if possible. I don't see a big negative effect to support tomcat extensions in the abstract impl so I'm proposing it as an option.
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le lun. 12 déc. 2022 à 11:25, Mark Thomas <ma...@apache.org> a écrit : > Can you expand on what problem you are trying to solve that you can't > solve with the current code? > > Mark > > > On 12/12/2022 09:51, Romain Manni-Bucau wrote: > > Hi all, > > > > Wonder if there is any reason to not push supported element of > > ExtendedAccessLogValve in the abstract log valve. > > Rational would be to leverage "extensions" in a custom log sink impl > (protected > > abstract void log(CharArrayWriter message);). > > > > Wdyt? > > Let me know if you are interested and I need to do a PR, would be more > than > > happy to help if relevant. > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
