I only did some changes to the docs and very small and non risky changes
to code.
I tested with apache 2.0.59 prefork and worker on Linux SLES 9 SP 2 64
Bit AMD. Tests looked OK.
Some comments:
1) Things to add to the changelog
=================================
I found the following changes, which are missing in the change log. Not
all of them need to go there, but maybe Mladen, Jean-Frederic, Guenter
and Henri can check, which ones they did and maybe add a line to the
change log:
- Fix html syntax in news docs pages
- jkrelease.sh: new users root:bin, automate file list for NEWS,
compress with gtar, don't set ANT_HOME and JAVA_HOME
- New build files on Win (nmake)
- Add tc 6 examples to config example and iis config example uriworkermap.
- apache: rename file_logger_t to jk_file_logger_t
- logging: refactor line endings logging to make it correct for all
platforms and webservers
- apache 1.3: rename child exit handler and add shm close
- apache 1.3: new child init handler with shm attach
- apache: add info level message during mod_jk startup with version info
- apache 2.2: win build env var APACHE22 und APACHE22_HOME and correct
apr/apr-1 distinction
- Fix whitespace in Netware make file
- Updates to iSeries Make file
- apache 2.0: use plog instead of pconf when initializing loggers
- Use fputs instead of fwrite in logging
- Translate charsets when dumping buffers and using EBCDIC
- Add worker names to some log messages in jk_ajp_common.c
2) Missing subversion properties corrected
==========================================
I added subversion properties
svn:eol-style native
svn:keywords 'Author Date Id Revision'
to the following win files, which had no props at all:
jk/native/iis/pcre/pcre.amd64
jk/native/iis/pcre/pcre.ia64
jk/native/iis/pcre/dftables.x86
jk/native/iis/pcre/pcre.x86
jk/native/iis/Makefile.ia64
jk/native/iis/Makefile.x86
jk/native/iis/Makefile.amd64
Also I changed their line endings to unix before setting the eol-style,
because I set it to native, so checking out on win should give them in
the correct win format.
Before my changes, some of those files had few lines with non-win endings:
jk/native/iis/pcre/pcre.amd64
.\dftables.exe chartables.c
type .\config.hw > .\config.h
type .\pcre.hw > .\pcre.h
jk/native/iis/pcre/pcre.ia64
.\dftables.exe chartables.c
type .\config.hw > .\config.h
type .\pcre.hw > .\pcre.h
jk/native/iis/pcre/dftables.x86
type .\config.hw > .\config.h
type .\pcre.hw > .\pcre.h
jk/native/iis/pcre/pcre.x86
.\dftables.exe chartables.c
type .\config.hw > .\config.h
type .\pcre.hw > .\pcre.h
No all line endings should be platform native. I hope that's correct.
The other files with no properties were all binaries (*.exe, *.gif,
*.ico, *.rtf). More precisely, I fixed a couple of non-IIS files, and
now the remaining ones are only binary formats.
3) fail_on_status
=================
Since fail_on_status is now multi-value, wouldn't it make sense for the
next (1.2.23) release, to also make it multi line. Apart from
fail_on_status, all worker attributes that allow multiple values can be
split over multiple lines, which for most of them allows a more
intuitive layout of the config file. I must confess, that there is no
very good reason for multi-line fail_on_status, apart from the fact,
that now it is the only attribute, that is multi-value but single line only.
The change should be as simple as moving STATUS_FAIL_OF_WORKER from
unique_properties to list_properties in common/jk_util.c
4) load_properties/load_property
================================
The new functions for loading properties to a map without any checks
could be folded into read_properties/read_property in 1.2.23 by adding a
new param, which decides on doing the checks. read_properties is
identical to load_properties apart from one line, and read_property is
an extension of load_property.
5) Reference links on NEWS file
===============================
The NEWS file contains links of the form in the reference section
file:///home/mturk/wrkplace/tomcat-connectors-1.1.22-dev-524775-src/
which is not a no go for the release. Using links (I use Links 2.1pre22)
instead of w3m or elinks (our release script scans for any of those)
does not produce the list of references at the bottom of the NEWS page,
so no local file system links will be in the document.
6) I didn't carefully check all the changes to jk_shm.c :(
==========================================================
7) Missing docs
===============
Mladen, maybe you can add a few lines to the two IIS docs pages about
the new cool URL rewriting? Or do you want to release the new feature in
stealth mode and document in 1.2.23?
The same for the new APACHE22 and APACHE22_HOME vars when building on Win.
8) BZ http://issues.apache.org/bugzilla/show_bug.cgi?id=42038
=============================================================
This is special to IIS. I think it's not a show stopper (it's also not
new), but interesting. Because IIS has the option of prefixing the URL
with the vhost name, exclusion mounts do not work, once you add /* the
the list of positive mounts.
9) JK_SHM_LOCK_REOPEN
=====================
What's the use of JK_SHM_LOCK_REOPEN?
Regards,
Rainer
Mladen Turk schrieb:
> Hi,
>
> The quality check release was out few days ago.
> I plan to tag the mod_jk tomorrow morning Europe time.
>
> Any objections?
>
> Regards,
> Mladen.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
