[tomcat] branch main updated: Improve: Reuse the instance of StringBuilder to avoid duplicate object creation (#588)

[lihan]

This is an automated email from the ASF dual-hosted git repository.

lihan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new 87e1cbf767 Improve: Reuse the instance of StringBuilder to avoid 
duplicate object creation (#588)
87e1cbf767 is described below

commit 87e1cbf7679fffdc0eeb620961d709681e564e3b
Author: Andrei Briukhov <andreybr...@gmail.com>
AuthorDate: Fri Feb 10 11:34:59 2023 +0300

    Improve: Reuse the instance of StringBuilder to avoid duplicate object 
creation (#588)
---
 java/org/apache/catalina/valves/ExtendedAccessLogValve.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
b/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
index 74dc8b871a..62faf87356 100644
--- a/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
+++ b/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
@@ -432,22 +432,22 @@ public class ExtendedAccessLogValve extends 
AccessLogValve {
                 switch (c) {
                 case ' ':
                     result = buf.toString();
-                    buf = new StringBuilder();
+                    buf.setLength(0);
                     buf.append((char) c);
                     return result;
                 case '-':
                     result = buf.toString();
-                    buf = new StringBuilder();
+                    buf.setLength(0);
                     subToken = true;
                     return result;
                 case '(':
                     result = buf.toString();
-                    buf = new StringBuilder();
+                    buf.setLength(0);
                     parameter = true;
                     return result;
                 case ')':
                     result = buf.toString();
-                    buf = new StringBuilder();
+                    buf.setLength(0);
                     break;
                 default:
                     buf.append((char) c);


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org