markt-asf commented on PR #578: URL: https://github.com/apache/tomcat/pull/578#issuecomment-1430113794
I've applied this change via a combination of IDE tools and manual review as the CheckStyle test for redundant modifiers covers more than just interface methods. I was initially in two minds whether to apply this but as I worked through it, I could see the benefits it offers in making the visibility - particularly of constructors - clearer. Prior to this patch, many were marked as public even though there were effectively package private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org