https://bz.apache.org/bugzilla/show_bug.cgi?id=66512

--- Comment #13 from Christopher Schultz <ch...@christopherschultz.net> ---
(In reply to Alexander Schüßler from comment #10)
> I am not a developer at my company but I found a suspicious piece of code in
> our codebase that would underline your assumption:

That does indeed look "suspicious". I would bet that the original developer was
trying to accommodate both clients who do and do not understand RFC
5987-encoded strings simultaneously. I wonder how that would actually behave
with each kind of client.

I would indeed change the code, but I would only use a single filename:

    response.setHeader ( "Content-Disposition",
            forceDownload
            + "; filename*=UTF-8''"
            + SysFacade.encodeFilename_for_HttpUrlAccess ( originalFileName )
);

Or, generate a "clean" version of your original filename that is known not to
contain any non-ASCII characters. I'll leave that as an exercise for the reader
;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to