isapir opened a new pull request, #598: URL: https://github.com/apache/tomcat/pull/598
We seem to have some duplication, e.g. `o.a.c.Globals.CATALINA_HOME_PROP` which is set from `o.a.c.startup.Constants.CATALINA_HOME_PROP`. Do we need `o.a.c.startup.Constants` to be separate for some reason, e.g. for packaging different JARs, or can we consolidate the code and use just `o.a.c.Globals` instead? The current PR does not modify that. It only replaces the literal strings `"catalina.home"` and `"catalina.base"` with constants from `Globals`, or in the `o.a.c.startup` package with `Constants`. I'm opening the PR so there are more eyes on it before I make the change, and will merge it after some reasonable time passes if no one raises any issues with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
