This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 6aa76c2d068d83a33d381780809080a26f071222 Author: Mark Thomas <ma...@apache.org> AuthorDate: Mon May 22 16:55:00 2023 +0100 Fix a couple of new false positives --- res/spotbugs/filter-false-positives.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml index 68a5b2d346..4cec867f47 100644 --- a/res/spotbugs/filter-false-positives.xml +++ b/res/spotbugs/filter-false-positives.xml @@ -140,6 +140,12 @@ <Field name="engine" /> <Bug pattern="IS2_INCONSISTENT_SYNC" /> </Match> + <Match> + </Match> + <!-- NPE is expected if Connector definition is invalid --> + <Class name="org.apache.catalina.connector.Connector"/> + <Method name="startInternal"/> + <Bug pattern="NP_NULL_ON_SOME_PATH"/> <Match> <!-- req.getRemoteUser(), req.getAuthType(), request.getQueryString() can return null because o.a.t.util.buf.MessageBytes.toString() can return NULL @@ -186,6 +192,12 @@ <Method name="logDebug"/> <Bug code="RCN"/> </Match> + <Match> + <!-- Sync isn't guarding this object --> + <Class name="org.apache.catalina.core.ContainerBase"/> + <Method name="setStartStopThreads"/> + <Bug pattern="IS2_INCONSISTENT_SYNC"/> + </Match> <Match> <!-- Exception caught deliberately --> <Class name="org.apache.catalina.core.NamingContextListener" /> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org