[GitHub] [tomcat] aooohan commented on a diff in pull request #648: Refactor 'getSession' Method in 'Request' Class to Eliminate Code Redundancy

[via GitHub]

aooohan commented on code in PR #648:
URL: https://github.com/apache/tomcat/pull/648#discussion_r1315332131


##########
java/org/apache/catalina/connector/Request.java:
##########
@@ -2288,12 +2288,7 @@ public String getServletPath() {
      */
     @Override
     public HttpSession getSession() {
-        Session session = doGetSession(true);
-        if (session == null) {
-            return null;
-        }
-
-        return session.getSession();
+        getSession(true);

Review Comment:
   No results returned.
   ```suggestion
           return getSession(true);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org