On Tue, Sep 5, 2023 at 1:48 PM Han Li <aooo...@gmail.com> wrote: > > Mark, > > I'm not a big fan of this type of PR, this kind of change in the form of a > code change and only a line or two, and I've noticed that the last few PRs > have come from the same place 'woowacourse', which I personally suspect is > what they need to accomplish, eg: task, and since tomcat has a long history > of problems with this form of code, if we allow this kind of change in the > form of a couple of lines of code PR submissions, then I I'm sure there > will be many more of these pointless PRs to show, so I still feel the need > to reject those PRs.
+1, as close to zero benefit as it gets, and lots of noise. Actually, it is not that far fetched that a large bunch of PRs like this could be used as an attempt to sneak in a harmful change. Rémy Rémy > > Han > > 在 2023年9月5日星期二，iamjooon2 (via GitHub) <g...@apache.org> 写道： > > > > > iamjooon2 opened a new pull request, #652: > > URL: https://github.com/apache/tomcat/pull/652 > > > > Hello! > > > > i deleted needless brackets for consistency with the other code. > > > > Thx :D > > > > > > -- > > This is an automated message from the Apache Git Service. > > To respond to the message, please log on to GitHub and use the > > URL above to go to the specific comment. > > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > > > For queries about this service, please contact Infrastructure at: > > us...@infra.apache.org > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > -- > Han Li --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
