markt-asf commented on code in PR #659:
URL: https://github.com/apache/tomcat/pull/659#discussion_r1316303250
##########
java/org/apache/catalina/manager/StatusTransformer.java:
##########
@@ -375,33 +375,33 @@ protected static void writeProcessorState(PrintWriter
writer,
switch (stage) {
- case (1/*org.apache.coyote.Constants.STAGE_PARSE*/):
+ case (Constants.STAGE_PARSE):
Review Comment:
Why not use the existing constants (the ones in the comments)?
##########
java/org/apache/coyote/Constants.java:
##########
@@ -37,9 +37,9 @@ public final class Constants {
public static final int STAGE_PARSE = 1;
public static final int STAGE_PREPARE = 2;
public static final int STAGE_SERVICE = 3;
- public static final int STAGE_ENDINPUT = 4;
- public static final int STAGE_ENDOUTPUT = 5;
- public static final int STAGE_KEEPALIVE = 6;
+ public static final int STAGE_END_INPUT = 4;
+ public static final int STAGE_END_OUTPUT = 5;
+ public static final int STAGE_KEEP_ALIVE = 6;
Review Comment:
We don't want to change the names of public constants unless we have a
really good reason. The risk of breaking a third-party integration is too high.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
