greeng00se opened a new pull request, #660: URL: https://github.com/apache/tomcat/pull/660
### Description Optimization when call getSessionCookieName & getSessionUriParamName ### Explanation Existing code calls getConfiguredSessionCookieName even if the context is empty. In getConfiguredSessionCookieName, only act to get the session cookie if the context is non-null. I think it's possible to avoid calling getConfiguredSessionCookieName and use Default defined by spec if context is null. It's a small optimisation, but I think it saves us one less function call. Additionally, modified getConfiguredSessionCookieName to not require a null check on its result. ### Comment One fewer comparison operation if context is non-null. and I think it makes the code a little easier to understand for the remaining priority comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
