markt-asf commented on code in PR #663:
URL: https://github.com/apache/tomcat/pull/663#discussion_r1316972689
##########
java/org/apache/catalina/startup/Tomcat.java:
##########
@@ -1303,7 +1303,7 @@ public static void main(String[] args) throws Exception {
break;
}
}
- org.apache.catalina.startup.Tomcat tomcat = new
org.apache.catalina.startup.Tomcat();
+ Tomcat tomcat = new Tomcat();
Review Comment:
The removal of the FQCN is fine but as the only remaining change is rather
small for the effort required to review and merge a PR. A PR that addressed
this for the entire code base (I believe there is a PMD rule to check for this)
would be useful.
##########
java/org/apache/catalina/startup/Tomcat.java:
##########
@@ -1290,9 +1290,9 @@ public static void main(String[] args) throws Exception {
// Process some command line parameters
String[] catalinaArguments = null;
for (int i = 0; i < args.length; i++) {
- if (args[i].equals("--no-jmx")) {
+ if ("--no-jmx".equals(args[i])) {
Review Comment:
The change to equals() is subjective. I'd argue the current code is easier
to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
