Jaeyoung22 commented on PR #661: URL: https://github.com/apache/tomcat/pull/661#issuecomment-1708220046
I've taken note of what you've said. ## 1. remove unnecessary parentheses throughout the package Personally, I find conditional statements with three or more conditions to be more readable with parentheses, so I changed all conditional statements with TWO conditions where each condition is wrapped in parentheses. ## 2. Simplify conditional expressions using DeMorgan's law As you mentioned, I recognized that not using DeMorgan's rule can be more readable, so I changed all conditional statements that use DeMorgan's rule to not use it. Please let me know if there are any conditional statements that you think would be better readable if they used DeMorgan's law. ## Comment This is my first PR contributing to open source, so there may be some imperfections. If I made a mistake or did something wrong, please forgive me and let me know. Thank you for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
