On 10/09/2023 10:21, rmaucher (via GitHub) wrote:

rmaucher commented on PR #669:
URL: https://github.com/apache/tomcat/pull/669#issuecomment-1712763013

    The ordering of these is often important. Please don't try to change this 
for cosmetic reason since it needs time and expertise to review.

Agreed re cosmetic changes.

In this case, I think there might be merit in the change in terms of simplifying the code and making future maintenance easier.

I've reviewed the patch and I can't see any reason not to make this change. Can anyone else see a reason not to do this?

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to