This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 71a0936bb6 Sync keepalive
71a0936bb6 is described below
commit 71a0936bb6bf52fee419538589e1ee18207b5947
Author: remm <r...@apache.org>
AuthorDate: Wed Sep 27 10:26:16 2023 +0200
Sync keepalive
The call seems risky with unsynced accesses to maps and the sender.
Found by coverity.
---
java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java
b/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java
index 02eaf45670..d8c5bec16a 100644
--- a/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java
+++ b/java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java
@@ -381,7 +381,7 @@ public class ParallelNioSender extends AbstractSender
implements MultiPointSende
}
@Override
- public boolean keepalive() {
+ public synchronized boolean keepalive() {
boolean result = false;
for (Iterator<Entry<Member,NioSender>> i =
nioSenders.entrySet().iterator(); i.hasNext();) {
Map.Entry<Member, NioSender> entry = i.next();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
