Igal,

On 10/9/23 18:53, Igal Sapir wrote:
Chris,

On Mon, Oct 9, 2023 at 3:22 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

Igal,

On 10/9/23 18:13, Igal Sapir wrote:
Chris,

I'm getting some errors when I run `ant clean test` with Java 1.8.0_322 -
any ideas?

Yes, you will need to set some build properties. Have a look at this
script and look ad what I do with the "opens":


https://github.com/ChristopherSchultz/apache-tomcat-stuff/blob/master/bin/test-tomcat-release.sh#L269


OK, now I got two failures (details below):

   [concat] Testsuites with failed tests:
   [concat] TEST-org.apache.tomcat.util.net.jsse.TestPEMFile.NIO2.txt

Hmm, I thought this was fixed for Java 8.something-earlier-than-yours. I'm using 1.8.0_372 on Linux and it passes all unit tests with this build.properties:

base.path=/path/to/downloads
execute.validate=true
java.7.home=/usr/local/java-7
opens.javalang=-Dnop
opens.javaio=-Dnop
opens.sunrmi=-Dnop
opens.javautil=-Dnop
opens.javautilconcurrent=-Dnop
test.openssl.unimplemented=IDEA
test.openssl.loc=/path/to/openssl

Maybe it behaves differently on Windows?


/workspace/build/tomcat/8.5.x/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainerSSL.NIO2.txt

Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainerSSL
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.864 sec
------------- Standard Error -----------------
09-Oct-2023 15:49:12.260 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[testConnectToServerEndpointSSL]
09-Oct-2023 15:49:13.038 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1"]
09-Oct-2023 15:49:13.327 INFO [main]
org.apache.tomcat.util.net.AbstractEndpoint.logCertificate Connector
[https-jsse-nio2-127.0.0.1-auto-1], TLS virtual host [
_default_], certificate type [UNDEFINED] configured from keystore
[/workspace/src/tomcat/8.5.x/test/org/apache/tomcat/util/net/localhost-rsa.jks]
using alias [t
omcat] with trust store
[/workspace/src/tomcat/8.5.x/test/org/apache/tomcat/util/net/ca.jks]
09-Oct-2023 15:49:13.341 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
[Tomcat]
09-Oct-2023 15:49:13.342 INFO [main]
org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
engine: [Apache Tomcat/8.5.94]
09-Oct-2023 15:49:13.633 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1-44075"]
09-Oct-2023 15:49:13.677 INFO [main]
org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1-44075"]
09-Oct-2023 15:49:13.679 INFO [main]
org.apache.catalina.core.StandardService.stopInternal Stopping service
[Tomcat]
09-Oct-2023 15:49:13.696 INFO [main]
org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1-44075"]
09-Oct-2023 15:49:13.702 INFO [main]
org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1-44075"]
------------- ---------------- ---------------

Testcase: testConnectToServerEndpointSSL took 1.793 sec
        Caused an ERROR
The HTTP request to initiate the WebSocket connection to
[wss://localhost:44075/echoAsync] failed
javax.websocket.DeploymentException: The HTTP request to initiate the
WebSocket connection to [wss://localhost:44075/echoAsync] failed
        at
org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:428)

        at
org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer(WsWebSocketContainer.java:170)

        at
org.apache.tomcat.websocket.TestWsWebSocketContainerSSL.testConnectToServerEndpointSSL(TestWsWebSocketContainerSSL.java:64)

Caused by: java.util.concurrent.ExecutionException:
javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is
disabled or cipher suites are inap
propriate)
        at
org.apache.tomcat.websocket.AsyncChannelWrapperSecure$WrapperFuture.get(AsyncChannelWrapperSecure.java:489)

        at
org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:320)

Caused by: javax.net.ssl.SSLHandshakeException: No appropriate protocol
(protocol is disabled or cipher suites are inappropriate)
        at
sun.security.ssl.HandshakeContext.<init>(HandshakeContext.java:171)
        at
sun.security.ssl.ClientHandshakeContext.<init>(ClientHandshakeContext.java:103)

        at
sun.security.ssl.TransportContext.kickstart(TransportContext.java:220)
        at
sun.security.ssl.SSLEngineImpl.beginHandshake(SSLEngineImpl.java:97)
        at
org.apache.tomcat.websocket.AsyncChannelWrapperSecure$WebSocketSslHandshakeThread.run(AsyncChannelWrapperSecure.java:347)

This one I cannot explain at all. Which connector failed this test? APR, NIO, or NIO2. They should all behave the same way, so if one of them fails I'd expect the others to fail. So if one of them fails, it may be some weird thing with that test-run.

Can you re-run that one unit test again to see if it fails again?

-chris

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to