Remy Maucherat wrote:
Filip Hanik - Dev Lists wrote:
Ok, I'll try something in the meantime in CoyoteAdapter, since it's
trivial (and I think does all that is needed at this point).
The available() has a side effect, if there is a partial or non valid
chunked header (ie the client also sends some garbage), available()
returns >0, and the read() goes into a forever blocking read as no
more data is coming in.
this was not the case before, as a READ event, you did one read, and
then available returned 0, and you'd be fine until next READ event.
since it's a client data error, I'm ok with it, question is, how
common are these client errors.
It doesn't really make a difference. Even if you do only one read
during the read event, it is possible to only send a portion of the
chunk header, causing the ChunkedInputBuffer to block if its previous
chunk was fully read (or if it is the first chunk). The only realistic
solution is to add a system property forbidding reads during parsing
of the chunk header, as I don't think it's a very reasonable situation.
I would be ok to tag 6.0.13 before doing any further functional
changes, as it contains numerous bugfixes since 6.0.10.
Let us wait a few days for these available() changes to get some
feedback, then we can tag and go through our stability tests.
Ok. I was ready to tag tomorrow evening before starting on the timeout
feature for APR, but I can wait more if you have changes to do
(otherwise, I don't think anyone is going to really test since it's
the WE). I can tag again if there's a horrible bug.
ok, tag away, I don't have more to commit at this time
Filip
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
