This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 45b4b3436e41c018efb095490f776f8683064963 Author: Mark Thomas <ma...@apache.org> AuthorDate: Wed Jan 3 10:42:01 2024 +0000 Don't flag a test as skipped that is never going to be able to pass --- test/org/apache/tomcat/util/net/TestXxxEndpoint.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java index 2fd3ab50f1..30c564c137 100644 --- a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java +++ b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java @@ -26,7 +26,6 @@ import java.nio.ByteBuffer; import java.nio.channels.SocketChannel; import org.junit.Assert; -import org.junit.Assume; import org.junit.Test; import org.apache.catalina.connector.Connector; @@ -90,8 +89,11 @@ public class TestXxxEndpoint extends TomcatBaseTest { public void testUnixDomainSocket() throws Exception { Tomcat tomcat = getTomcatInstance(); Connector c = tomcat.getConnector(); - Assume.assumeTrue("NIO Unix domain sockets have to be supported for this test", - c.getProtocolHandlerClassName().contains("NioProtocol")); + + if (!c.getProtocolHandlerClassName().contains("NioProtocol")) { + // Only the NIO connector supports UnixDomainSockets + return; + } File tempPath = File.createTempFile("uds-tomcat-test-", ".sock"); String unixDomainSocketPath = tempPath.getAbsolutePath(); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org