ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1875476100
> > Re 4: I think that if one is wise enough to write a RegExp, they could use "|" to combine several patterns, and do not really need splitting by comma. > > I suppose if you are going to use a regular expression, maybe the entire pattern should be used since regex is very expensive already. After thinking about this for a while, I agree with @kkolinko on this one: a regular expression is going to be expensive enough to run that the user may as well implement the whole matching pattern in a single regular expression instead of having Tomcat chop it up into little pieces and potentially run multiple regular expression matches for every URL-check. I will change the implementation to allow *either* a single regular expression (offset by leading `/` and trailing `/` characters) *or* a series of simpler comma-separated matchers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
