ChristopherSchultz commented on code in PR #707:
URL: https://github.com/apache/tomcat/pull/707#discussion_r1527524948
##########
java/org/apache/catalina/realm/JNDIRealm.java:
##########
@@ -966,7 +967,7 @@ private String[] getCipherSuitesArray() {
containerLog.warn(sm.getString("jndiRealm.emptyCipherSuites"));
this.cipherSuitesArray = null;
} else {
- this.cipherSuitesArray = cipherSuites.trim().split("\\s*,\\s*");
+ this.cipherSuitesArray =
StringUtils.splitCommaSeparated(cipherSuites.trim());
if (containerLog.isTraceEnabled()) {
Review Comment:
It turns out its doubly-redundant. It's "gone" but it's still there because
the condition above also needs to trim the string to check for empty-string.
But now we are only trimming once in this method instead of twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
