ChristopherSchultz commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2237137467
There isn't much here that isn't Virtual Thread friendly. VTs will indeed be pinned while running a synchronized block (at least in today's JVMs), but these blocks are short and shouldn't cause much delay in any kind of processing. Adding the use of a `Lock` could be done but IMHO isn't necessary as it merely introduces more lines of code at the expense of readability and potential bugs (it's difficult to screw-up a `synchronized` block and much easier to do use the `Lock` incorrectly). This just looks like a patch that is looking for a reason to apply it. I see no reason whatsoever. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
