On Thu, Jan 30, 2025 at 11:21 AM Mark Thomas <ma...@apache.org> wrote: > > On 30/01/2025 09:36, Rémy Maucherat wrote: > > On Thu, Jan 30, 2025 at 12:26 AM <build...@apache.org> wrote: > >> > >> Build status: BUILD FAILED: failed compile (failure) > >> Worker used: bb_worker2_ubuntu > >> URL: https://ci2.apache.org/#builders/112/builds/1490 > >> Blamelist: remm <r...@apache.org> > >> Build Text: failed compile (failure) > >> Status Detected: new failure > >> Build Source Stamp: [branch 11.0.x] > >> 86862a7544bded47734b565e19de5f1b7e8f5ea1 > > > > It seems I found an issue in ChunkedInputFilter in the end. > > > > It was working fine for me locally before I committed, but only > > because I had a different code in available() (going for a less > > hackish way to skip the CRLF - and also the chunk header). > > Simply removing the code that was added to available() for CRLF also > > fixes the test. > > > > Investigating ... [but this is very mysterious for now] > > I'm looking too. Looks like an off by one issue somewhere but I can't > see where yet. Need to add more local debug logging to ChunkedInputFilter.
Yes, there's an off by one issue, still don't understand what's causing it (anything that gets into the available = 0 situations in available() will break). My local code replaces the CRLF trick with proper byte skipping and does not have the issue. I'll commit it to see if the testsuite on CI is ok with it. Note: TestChunkedInputFilter is skipped in the GH actions due to taking too much time to complete, which is why I didn't immediately notice it. Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
