dsoumis commented on PR #828: URL: https://github.com/apache/tomcat/pull/828#issuecomment-2661457556
1) Please ensure that you run ant validate or use Checkstyle tool with the checkstyle rules provided before submitting a PR. There are currently some checkstyle errors in your import statements. 2) Consider utilizing EasyMock class instead of creating "Fake" classes for isolated testing. You may look into TestSSLValve.java for reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
