markt-asf commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2663380820
That looks good for for the `ExtendedAccessLogValve`.
I don't like that this is automatically added as a request attribute.
Firstly, if we add this field, why not all the others? Secondly, it seems wrong
to add this as an attribute when there is a perfectly good API to obtain the
ID. I think that means AccessLogValve needs something like `x-H(XXX)`. The
question is what to use since we try and keep this aligned with httpd and we
don't know what they'll choose to do in the future. Maybe `%{XXX}x`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
