Am 02.03.25 um 17:07 schrieb Rainer Jung:
Hi Rémy,

Am 02.03.25 um 11:06 schrieb Rémy Maucherat:
On Thu, Feb 13, 2025 at 6:11 PM <ma...@apache.org> wrote:
@@ -163,6 +157,9 @@ Var ServiceInstallLog
    InstType Minimum
    InstType Full

+  !finalize 'ant -f @BASEDIR@/build.xml jsign-installer'
+  !uninstfinalize 'ant -f @BASEDIR@/build.xml - Dcodesigning.file_to_sign=%1 jsign-uninstaller'

This fails for me with Can't recognize xxx as an internal or external
command, or batch script.
I tried a few things without much success so far.

First the original nsi script should automatically be run by ant through a filter to generate one without @ template strings. Originally the filter replaced version numbers, but in the new build.xml it also replaces BASEDIR. The resulting file would be the one used by makensis. Maybe it makes sense to check, how those lines look like in your environment in the generated file.

The other possible problem could be, that ant is not found via PATH. What is "xxx"? just the full "ant -f ...jsign-installer"? With or without replaced BASEDIR? What is your platform? Maybe we would have to change something on Windows?

I should add: if it only happens for the uninstfinalize and not for finalize, there is one major difference between the two. The file to sign for finalize has the final name of the installer file. The file to sign in uninstfinalize is a temporary file generated by makensis during running the installer generation script. So this temporary mapth might also be interesting (hidden in "%1" and passed to ant via codesigning.file_to_sign.

Best regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to