On 29/04/2025 16:30, Christopher Schultz wrote:
On 4/29/25 3:50 AM, ma...@apache.org wrote:
<snip/>
The following commit(s) were added to refs/heads/11.0.x by this push:
new fab7247d2f Refactor CGI servlet to access resources via
WebResources
fab7247d2f is described below
commit fab7247d2f0e3a29d5daef565f829f383e10e5e2
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Apr 28 12:58:21 2025 +0100
<snip/>
+ protected String[] findCGI(String contextPath, String
servletPath, String pathInfo, String cgiPathPrefix) {
I know it wasn't your goal to clean any of this up, but I think a custom
class would be better for this application than String[].
Any objections to be re-factoring this to use a new class?
I thought about it but opted not to. No objections to this being done.
<snip/>
- protected void expandCGIScript() {
I know it would have to be written a little differently, but why remove
this separate method? I think using the separate method makes the
calling code easier to read.
I removed the separate method because it tried to duplicate the search
algorithm from findCGI but was actually doing somethign slightly different.
I'm not against refactoring into multiple methods as long as it doesn't
re-introduce duplication.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
