This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 15ad6b2870 Improve formatting
15ad6b2870 is described below
commit 15ad6b28705f762c95c7edeb9e8ba7248846b28f
Author: Mark Thomas <[email protected]>
AuthorDate: Thu May 22 18:00:08 2025 +0100
Improve formatting
---
.../apache/tomcat/util/net/SocketProperties.java | 56 ++++++++++------------
1 file changed, 24 insertions(+), 32 deletions(-)
diff --git a/java/org/apache/tomcat/util/net/SocketProperties.java
b/java/org/apache/tomcat/util/net/SocketProperties.java
index cd2e70e4ea..4e911e9bf8 100644
--- a/java/org/apache/tomcat/util/net/SocketProperties.java
+++ b/java/org/apache/tomcat/util/net/SocketProperties.java
@@ -42,34 +42,34 @@ public class SocketProperties {
/**
* Enable/disable socket processor cache, this bounded cache stores
- * SocketProcessor objects to reduce GC
- * Default is 500
- * -1 is unlimited
+ * SocketProcessor objects to reduce GC.
+ * <p>
+ * Default is 500<br>
+ * -1 is unlimited<br>
* 0 is disabled
- * TODO: The default will be changed to 0 in Tomcat 10
*/
protected int processorCache = 500;
/**
* Enable/disable poller event cache, this bounded cache stores
* PollerEvent objects to reduce GC for the poller
+ * <p>
* Default is 500
- * -1 is unlimited
- * 0 is disabled
+ * -1 is unlimited<br>
+ * 0 is disabled<br>
* >0 the max number of objects to keep in cache.
- * TODO: The default will be changed to 0 in Tomcat 10
*/
protected int eventCache = 500;
/**
- * Enable/disable direct buffers for the network buffers
- * Default value is disabled
+ * Enable/disable direct buffers for the network buffers.
+ * Default value is disabled.
*/
protected boolean directBuffer = false;
/**
- * Enable/disable direct buffers for the network buffers for SSL
- * Default value is disabled
+ * Enable/disable direct buffers for the network buffers for SSL.
+ * Default value is disabled.
*/
protected boolean directSslBuffer = false;
@@ -87,40 +87,32 @@ public class SocketProperties {
/**
* The application read buffer size in bytes.
- * Default value is rxBufSize
+ * Default value is rxBufSize.
*/
protected int appReadBufSize = 8192;
/**
- * The application write buffer size in bytes
- * Default value is txBufSize
+ * The application write buffer size in bytes.
+ * Default value is txBufSize.
*/
protected int appWriteBufSize = 8192;
/**
* NioChannel pool size for the endpoint,
- * this value is how many channels
- * -1 means unlimited cached, 0 means no cache
- * Default value is 500
- * TODO: The default should be changed in Tomcat 10, actually it should be
- * bufferPoolSize / (appReadBufSize + appWriteBufSize), assuming the SSL
- * buffers are ignored (that would be logical), and the value would be
6400.
- * So the default value will be changed to a new default value like -2 to
- * set a dynamic value based on bufferPoolSize in that case.
+ * this value is how many channels.
+ * <p>
+ * Default value is 500<br>
+ * 0 means no cache<br>
+ * -1 means unlimited cached
*/
protected int bufferPool = 500;
/**
- * Buffer pool size in bytes to be cached
- * -1 means unlimited, 0 means no cache
- * Default value is 100MB (1024*1024*100 bytes)
- * TODO: The default value to be used could rather be based on the
- * JVM max heap, otherwise it could be a problem in some
- * environments. Big servers also need to use a much higher default,
- * while small cloud based ones should use 0 instead.
- * Possible default value strategy:
- * heap inf 1GB: 0
- * heap sup 1GB: heap / 32
+ * Buffer pool size in bytes to be cached.
+ * <p>
+ * Default value is 100MB (1024*1024*100 bytes)<br>
+ * -1 means unlimited<br>
+ * 0 means no cache
*/
protected int bufferPoolSize = 1024*1024*100;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
