aogburn commented on PR #882: URL: https://github.com/apache/tomcat/pull/882#issuecomment-3192741258
Thanks for the feedback @ChristopherSchultz. That primarily happened as I was trying to ensure that `load` obtained and kept its lock from the time it confirmed the file exists through to the completion of its read since any delete/modification between could lead to an unexpected result. And I didn't add any extra `exists()` check originally so just grabbed the lock on the intro to `load` instead. That should look better now though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
