markt-asf commented on PR #78: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/78#issuecomment-3199707123
I'll just note that that patch uses `|` and not `||` so there is no short-circuiting of the logic if `convertedArchive` is `true`. I haven't reviewed the rest of the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org