On Tue, Aug 19, 2025 at 9:02 AM Mark Thomas <ma...@apache.org> wrote:
>
> All,
>
> I stumbled across quite few instances of log messages like this while I
> was looking at something for $dayjob:
>
> log.error(sm.getString("naming.bindFailed", e));
>
> It would be lot more useful with the stack trace so I think that really
> should be:
>
> log.error(sm.getString("naming.bindFailed"), e);
>
>
> Unless there are objections, I am going to change any log message with a
> level of warning or greater that currently includes e, e.toString(),
> e.getMessage() etc in the log message and doesn't log the full stack
> trace to log the stack trace. I'll likely remove the exception from the
> log message as well to avoid duplicating the text in the logs.
>
> INFO level and is a little different. Those need looking at on a case by
> case basis as I can imagine there are some cases where logging the full
> stack trace is not necessary.Sometimes the exception message is more than enough though. I think the whole thing could be case by case. Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
