This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 2e82f3e9a6 Review trace level logging
2e82f3e9a6 is described below
commit 2e82f3e9a62f20ade219f13a36ec70c9cae99348
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Aug 19 17:29:55 2025 +0100
Review trace level logging
---
java/org/apache/catalina/realm/JNDIRealm.java | 2 +-
java/org/apache/catalina/servlets/CGIServlet.java | 2 +-
java/org/apache/catalina/tribes/Channel.java | 2 +-
java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java | 3 ++-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/catalina/realm/JNDIRealm.java
b/java/org/apache/catalina/realm/JNDIRealm.java
index 0b8bf3c4f1..954abd9411 100644
--- a/java/org/apache/catalina/realm/JNDIRealm.java
+++ b/java/org/apache/catalina/realm/JNDIRealm.java
@@ -1850,7 +1850,7 @@ public class JNDIRealm extends RealmBase {
validated = true;
} catch (AuthenticationException e) {
if (containerLog.isTraceEnabled()) {
- containerLog.trace(" bind attempt failed");
+ containerLog.trace(" bind attempt failed", e);
}
} finally {
// Restore GSSAPI SASL if previously configured
diff --git a/java/org/apache/catalina/servlets/CGIServlet.java
b/java/org/apache/catalina/servlets/CGIServlet.java
index 8ca68c1993..67e0b78adb 100644
--- a/java/org/apache/catalina/servlets/CGIServlet.java
+++ b/java/org/apache/catalina/servlets/CGIServlet.java
@@ -425,7 +425,7 @@ public final class CGIServlet extends HttpServlet {
}
}
} catch (IllegalStateException ise) {
- log.trace("Request Parameters: [Invalid]");
+ log.trace("Request Parameters: [Invalid]", ise);
}
log.trace("Protocol: [" + req.getProtocol() + "]");
log.trace("Remote Address: [" + req.getRemoteAddr() + "]");
diff --git a/java/org/apache/catalina/tribes/Channel.java
b/java/org/apache/catalina/tribes/Channel.java
index 923504043b..988b2015f8 100644
--- a/java/org/apache/catalina/tribes/Channel.java
+++ b/java/org/apache/catalina/tribes/Channel.java
@@ -500,7 +500,7 @@ public interface Channel {
} catch (NumberFormatException nfe) {
final Log log = LogFactory.getLog(Channel.class);
log.trace(String.format("Failed to parse [%s] as integer,
channelSendOptions possibly set by name(s)",
- input));
+ input), nfe);
}
String[] options = input.split("\\s*,\\s*");
diff --git
a/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
b/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
index 4dff0dfa7d..aa65ace7bf 100644
--- a/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
+++ b/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
@@ -213,7 +213,8 @@ public class NioReplicationTask extends AbstractRxTask {
try {
Logs.MESSAGES.trace("NioReplicationThread - Received
msg:" + new UniqueId(msg.getUniqueId()) +
" at " + new
java.sql.Timestamp(System.currentTimeMillis()));
- } catch (Throwable t) {
+ } catch (Throwable ignore) {
+ // Ignore
}
}
// process the message
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
