This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 1ff94a0370 Review info level logging with exceptions
1ff94a0370 is described below
commit 1ff94a03705aaa0d065f77d3b8a8e65e23954698
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Aug 20 15:42:41 2025 +0100
Review info level logging with exceptions
---
java/org/apache/catalina/loader/WebappClassLoaderBase.java | 5 ++---
java/org/apache/catalina/startup/Catalina.java | 2 +-
java/org/apache/catalina/startup/ContextConfig.java | 2 +-
java/org/apache/catalina/startup/ListenerCreateRule.java | 2 +-
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/java/org/apache/catalina/loader/WebappClassLoaderBase.java
b/java/org/apache/catalina/loader/WebappClassLoaderBase.java
index f1ee8a4d6e..ef2e0ba035 100644
--- a/java/org/apache/catalina/loader/WebappClassLoaderBase.java
+++ b/java/org/apache/catalina/loader/WebappClassLoaderBase.java
@@ -1206,9 +1206,8 @@ public abstract class WebappClassLoaderBase extends
URLClassLoader
// It is not permitted to load resources once the web application has
// been stopped.
if (!state.isAvailable()) {
- String msg = sm.getString("webappClassLoader.stopped", resource);
- IllegalStateException ise = new IllegalStateException(msg);
- log.info(msg, ise);
+ IllegalStateException ise = new
IllegalStateException(sm.getString("webappClassLoader.stopped", resource));
+ log.info(ise.getMessage(), ise);
throw ise;
}
}
diff --git a/java/org/apache/catalina/startup/Catalina.java
b/java/org/apache/catalina/startup/Catalina.java
index 02da480baa..45f91e00e6 100644
--- a/java/org/apache/catalina/startup/Catalina.java
+++ b/java/org/apache/catalina/startup/Catalina.java
@@ -547,7 +547,7 @@ public class Catalina {
Digester.setGeneratedCodeLoader(loader);
} catch (Exception e) {
if (log.isDebugEnabled()) {
- log.info(sm.getString("catalina.noLoader",
loaderClassName), e);
+ log.debug(sm.getString("catalina.noLoader",
loaderClassName), e);
} else {
log.info(sm.getString("catalina.noLoader",
loaderClassName));
}
diff --git a/java/org/apache/catalina/startup/ContextConfig.java
b/java/org/apache/catalina/startup/ContextConfig.java
index b7144c77a0..8b79e8eb3a 100644
--- a/java/org/apache/catalina/startup/ContextConfig.java
+++ b/java/org/apache/catalina/startup/ContextConfig.java
@@ -1776,7 +1776,7 @@ public class ContextConfig implements LifecycleListener {
ht = sci.getClass().getAnnotation(HandlesTypes.class);
} catch (Exception e) {
if (log.isDebugEnabled()) {
- log.info(sm.getString("contextConfig.sci.debug",
sci.getClass().getName()), e);
+ log.debug(sm.getString("contextConfig.sci.debug",
sci.getClass().getName()), e);
} else {
log.info(sm.getString("contextConfig.sci.info",
sci.getClass().getName()));
}
diff --git a/java/org/apache/catalina/startup/ListenerCreateRule.java
b/java/org/apache/catalina/startup/ListenerCreateRule.java
index 6cfb75ceae..e530f0b7c9 100644
--- a/java/org/apache/catalina/startup/ListenerCreateRule.java
+++ b/java/org/apache/catalina/startup/ListenerCreateRule.java
@@ -49,7 +49,7 @@ public class ListenerCreateRule extends ObjectCreateRule {
} catch (Exception e) {
String className = getRealClassName(attributes);
if (log.isDebugEnabled()) {
- log.info(sm.getString("listener.createFailed", className),
e);
+ log.debug(sm.getString("listener.createFailed",
className), e);
} else {
log.info(sm.getString("listener.createFailed", className));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
