This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push: new c514c62c9b Review info level logging with exceptions c514c62c9b is described below commit c514c62c9be650410b630b717c1201a62ce93ee2 Author: Mark Thomas <ma...@apache.org> AuthorDate: Wed Aug 20 15:42:41 2025 +0100 Review info level logging with exceptions --- java/org/apache/catalina/loader/WebappClassLoaderBase.java | 5 ++--- java/org/apache/catalina/startup/Catalina.java | 2 +- java/org/apache/catalina/startup/ContextConfig.java | 2 +- java/org/apache/catalina/startup/ListenerCreateRule.java | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/java/org/apache/catalina/loader/WebappClassLoaderBase.java b/java/org/apache/catalina/loader/WebappClassLoaderBase.java index e16b4769d1..6470e9c2e6 100644 --- a/java/org/apache/catalina/loader/WebappClassLoaderBase.java +++ b/java/org/apache/catalina/loader/WebappClassLoaderBase.java @@ -1370,9 +1370,8 @@ public abstract class WebappClassLoaderBase extends URLClassLoader // It is not permitted to load resources once the web application has // been stopped. if (!state.isAvailable()) { - String msg = sm.getString("webappClassLoader.stopped", resource); - IllegalStateException ise = new IllegalStateException(msg); - log.info(msg, ise); + IllegalStateException ise = new IllegalStateException(sm.getString("webappClassLoader.stopped", resource)); + log.info(ise.getMessage(), ise); throw ise; } } diff --git a/java/org/apache/catalina/startup/Catalina.java b/java/org/apache/catalina/startup/Catalina.java index 8b5dcaf7ac..fb1d05eaec 100644 --- a/java/org/apache/catalina/startup/Catalina.java +++ b/java/org/apache/catalina/startup/Catalina.java @@ -525,7 +525,7 @@ public class Catalina { Digester.setGeneratedCodeLoader(loader); } catch (Exception e) { if (log.isDebugEnabled()) { - log.info(sm.getString("catalina.noLoader", loaderClassName), e); + log.debug(sm.getString("catalina.noLoader", loaderClassName), e); } else { log.info(sm.getString("catalina.noLoader", loaderClassName)); } diff --git a/java/org/apache/catalina/startup/ContextConfig.java b/java/org/apache/catalina/startup/ContextConfig.java index 93ee06451b..48afaa8a57 100644 --- a/java/org/apache/catalina/startup/ContextConfig.java +++ b/java/org/apache/catalina/startup/ContextConfig.java @@ -1787,7 +1787,7 @@ public class ContextConfig implements LifecycleListener { ht = sci.getClass().getAnnotation(HandlesTypes.class); } catch (Exception e) { if (log.isDebugEnabled()) { - log.info(sm.getString("contextConfig.sci.debug", sci.getClass().getName()), e); + log.debug(sm.getString("contextConfig.sci.debug", sci.getClass().getName()), e); } else { log.info(sm.getString("contextConfig.sci.info", sci.getClass().getName())); } diff --git a/java/org/apache/catalina/startup/ListenerCreateRule.java b/java/org/apache/catalina/startup/ListenerCreateRule.java index 6cfb75ceae..e530f0b7c9 100644 --- a/java/org/apache/catalina/startup/ListenerCreateRule.java +++ b/java/org/apache/catalina/startup/ListenerCreateRule.java @@ -49,7 +49,7 @@ public class ListenerCreateRule extends ObjectCreateRule { } catch (Exception e) { String className = getRealClassName(attributes); if (log.isDebugEnabled()) { - log.info(sm.getString("listener.createFailed", className), e); + log.debug(sm.getString("listener.createFailed", className), e); } else { log.info(sm.getString("listener.createFailed", className)); } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org