markt-asf commented on PR #887: URL: https://github.com/apache/tomcat/pull/887#issuecomment-3241474521
Big +1 to expanding the coverage of the unit tests. I was concerned about setting the system property impacting other tests but that is not an issue for tests run via Ant as each test class is tested in a separate JVM (by default and we haven't changed that). Tests run in the IDE will run in a single JVM but normally it is only single tests (or a package of tests) that are run so that won't normally be an issue. My other concern is that there are two things being tested here. 1) that setting `STRICT_SERVLET_COMPLIANCE` enables XML validation and 2) that XML validation works as expected. I think it might be better to split that into two tests. One testing that the XML validation works (configured using the Context attributes) and one testing that setting `STRICT_SERVLET_COMPLIANCE` sets the attributes it is documented to set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
