ChristopherSchultz commented on PR #901: URL: https://github.com/apache/tomcat/pull/901#issuecomment-3328147221
Mark, Replying on-list because it's not really a part of the conversation. Should we post this to users@ as well? This is probably far more relevant to users of Tomcat than just to those who follow the dev@ mailing list. -chris On 9/24/25 5:32 AM, Mark Thomas wrote: > Adding nanosecond resolution to the access log for 9.0.x is non-trivial > because all the interface methods for access logging expect request > duration to be passed in milliseconds. > > The current state of 9.0.x is that some preparatory commits have been > applied that should not change the current behaviour although they do > add a little overhead. > > I think we have three options: > > 1. Don't provide nanosecond resolution to the access logs for 9.0.x. > Revert the preparatory commits. > 2. Apply just the first of the commits in this PR. This is less > invasive BUT changes nearly all of the various interface methods for > access logging from milliseconds to nanoseconds. This might have > backwards compatibility issues for some users although the most > likely point of extension - custom access logging - is implemented > in so that they should be compatible. > 3. Apply both commits in this PR. It is more invasive but should be > backwards compatible for everyone. > > Regardless of what we do with this PR, we have changed the meaning of > request duration in the interface methods for access logging between > 9.0.x and 10.1.x (actually 10.0.x). That decision has already been made > so we just have to live with it. > > If we adopt option 2 or 3, there will likely be a clean-up commit > afterwards to mark various unused methods as deprecated in 9.0.x to > 11.0.x and remove them in 12.0.x > > ------------------------------------------------------------------------ > > > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/tomcat/pull/901 <https://github.com/apache/ > tomcat/pull/901> > > > Commit Summary > > * 8e3dbf7 <https://github.com/apache/tomcat/pull/901/ > commits/8e3dbf7792fc54f581fe1da4e172347f88f83e66> Make nanosecond > resolution available to access log for request start > * 579df83 <https://github.com/apache/tomcat/pull/901/ > commits/579df837eae54c094b2fc3c95a3ab00009036050> Avoid changing > method parameter from millis to nanos > > > File Changes > > (16 files <https://github.com/apache/tomcat/pull/901/files>) > > * *M* java/org/apache/catalina/AccessLog.java <https://github.com/ > apache/tomcat/pull/901/files#diff- > b802de9d4b175d368684559e42620d72713a0597863dae8de4f603b7e40c6fe7> (19) > * *M* java/org/apache/catalina/Container.java <https://github.com/ > apache/tomcat/pull/901/ > files#diff-8e7818c5d6449dc06e32af142a1d1bb096c0c5aed856a9c123bc85ecf6aefd2b> (22) > * *M* java/org/apache/catalina/connector/CoyoteAdapter.java <https:// > github.com/apache/tomcat/pull/901/ > files#diff-57ef7b19fef6b47438c66d3adc8aa47bdbe719d63bcfcd57be981e9d5b92fad8> (38) > * *M* java/org/apache/catalina/core/AccessLogAdapter.java <https:// > github.com/apache/tomcat/pull/901/ > files#diff-9aa876bff80c263df42b5f6c70f8867e1516a23c420b25a0eddcc1f8f982536a> (9) > * *M* java/org/apache/catalina/core/ContainerBase.java <https:// > github.com/apache/tomcat/pull/901/ > files#diff-78311b8732c58459afde26e406a2625c40c03f6f454b2fb3b0925156c0e84c7b> (11) > * *M* java/org/apache/catalina/core/StandardEngine.java <https:// > github.com/apache/tomcat/pull/901/ > files#diff-278b5b948475b982cf1f1ac4704ec142d6d8a6daaca8a24ac533219452657dbb> (7) > * *M* java/org/apache/catalina/valves/AbstractAccessLogValve.java > <https://github.com/apache/tomcat/pull/901/ > files#diff-2a57b3aba46c5951ddee8deb44f6e415f08899734b938fd114ceb7ffc1a4df14> (238) > * *M* java/org/apache/catalina/valves/ExtendedAccessLogValve.java > <https://github.com/apache/tomcat/pull/901/ > files#diff-5370afc26ebfcc3f59d5d12e64819179c007d9045c528f8cddc87761bdea47fe> (60) > * *M* java/org/apache/catalina/valves/JDBCAccessLogValve.java > <https://github.com/apache/tomcat/pull/901/ > files#diff-0ffe5860da90215423e57dca3ce113ca6ccd08c797e4532e6cef4fdd1800e156> (7) > * *M* java/org/apache/catalina/valves/JsonAccessLogValve.java > <https://github.com/apache/tomcat/pull/901/ > files#diff-084bbfd9f15a3ef276f928d0055bd5faba0e17e1433880394640f1058a49e1bf> (7) > * *M* java/org/apache/coyote/AbstractProcessor.java <https:// > github.com/apache/tomcat/pull/901/files#diff- > bc9d5b65c1e31de6caeae6aadf4e2486083c13b672a5ba08017204acf779b23b> (2) > * *M* java/org/apache/coyote/Adapter.java <https://github.com/apache/ > tomcat/pull/901/files#diff- > cfee1b22107722bbc875c9dce123bca0295322459b0eafd55de3d4ba17a0d0e5> (19) > * *M* java/org/apache/coyote/ajp/AjpProcessor.java <https:// > github.com/apache/tomcat/pull/901/ > files#diff-1deb13e1c86c59e8b55a49113760ab55db2a94ce79cb16b33f905220b8c09fb0> (6) > * *M* java/org/apache/coyote/http11/Http11Processor.java <https:// > github.com/apache/tomcat/pull/901/ > files#diff-3fd867b9b4e7488375a3a6f3f3f8143dac4ee1aa0edfb4e005dfffb051942508> (7) > * *M* java/org/apache/coyote/http2/StreamProcessor.java <https:// > github.com/apache/tomcat/pull/901/files#diff- > f9d5625a3f3ec1237038094517cf873af5daeb3c21ffb6c481d651f20441acd4> (3) > * *M* webapps/docs/changelog.xml <https://github.com/apache/tomcat/ > pull/901/ > files#diff-57d2f0a72170743f6c3687a48997b2aa37d8d209efe200f00a0b9dc51fc7e572> (4) > > > Patch Links: > > * https://github.com/apache/tomcat/pull/901.patch <https://github.com/ > apache/tomcat/pull/901.patch> > * https://github.com/apache/tomcat/pull/901.diff <https://github.com/ > apache/tomcat/pull/901.diff> > > — > Reply to this email directly, view it on GitHub <https://github.com/ > apache/tomcat/pull/901>, or unsubscribe <https://github.com/ > notifications/unsubscribe-auth/ > AC5COWJCDY5U3ADI5H4BC533UJQLDAVCNFSM6AAAAACHLM5B3WVHI2DSMVQWIX3LMV43ASLTON2WKOZTGQ2DQNJVGI2TCNY>. > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
