markt-asf commented on code in PR #902:
URL: https://github.com/apache/tomcat/pull/902#discussion_r2378332304
##########
java/org/apache/catalina/valves/CrawlerSessionManagerValve.java:
##########
@@ -263,8 +274,11 @@ public void invoke(Request request, Response response)
throws IOException, Servl
}
}
+ private String getClientIdentifier(Request request) {
+ return getClientIdentifierDefault(request.getHost(),
request.getContext(), request.getRemoteAddr());
+ }
- private String getClientIdentifier(Host host, Context context, String
clientIp) {
+ private String getClientIdentifierDefault(Host host, Context context,
String clientIp) {
Review Comment:
Why have two private methods here? Wouldn't it be simpler to merge these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
