ChristopherSchultz commented on PR #87: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/87#issuecomment-3417498390
I like the idea, but I do have two comments: 1. The cache seems to grow without bounds, and is on by default, and is silent. I would make this an opt-in feature instead of opt-out. 2. I'm a little concerned by this line: ``` byte[] convertedBytes = conversionBuffer.toByteArray(); ``` Is there no way to write the `conversionBuffer` to the destination without buffering the whole thing in memory? I guess most JARs are only a few MB but I generally prefer streaming whenever possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
