This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 233f50072c Remainder of formatting fixes now CI is working
233f50072c is described below
commit 233f50072ccf0e235da7b2f709c562765888bf04
Author: Mark Thomas <[email protected]>
AuthorDate: Fri Nov 21 14:11:55 2025 +0000
Remainder of formatting fixes now CI is working
---
java/org/apache/tomcat/util/buf/Asn1Writer.java | 2 +-
java/org/apache/tomcat/util/net/SSLHostConfig.java | 1 +
.../apache/tomcat/util/net/SocketWrapperBase.java | 2 +-
.../tomcat/util/net/TLSClientHelloExtractor.java | 4 ++--
.../tomcat/util/net/openssl/ciphers/Group.java | 5 +++--
.../util/net/openssl/ciphers/SignatureScheme.java | 5 +++--
.../util/net/openssl/panama/OpenSSLEngine.java | 6 ++++--
java/org/apache/tomcat/util/openssl/openssl_h.java | 3 ++-
.../tomcat/util/openssl/openssl_h_Macros.java | 4 ++--
java/org/apache/tomcat/websocket/Util.java | 24 +++++++++++-----------
.../tomcat/websocket/server/UpgradeUtil.java | 6 +++---
11 files changed, 34 insertions(+), 28 deletions(-)
diff --git a/java/org/apache/tomcat/util/buf/Asn1Writer.java
b/java/org/apache/tomcat/util/buf/Asn1Writer.java
index 4da8f13d94..c0433c0103 100644
--- a/java/org/apache/tomcat/util/buf/Asn1Writer.java
+++ b/java/org/apache/tomcat/util/buf/Asn1Writer.java
@@ -83,7 +83,7 @@ public class Asn1Writer {
result[1] = (byte) (128 + lengthSize);
int i = lengthSize;
while (dataSize > 0) {
- result[i+1] = (byte) (dataSize & 0xFF);
+ result[i + 1] = (byte) (dataSize & 0xFF);
dataSize = dataSize >> 8;
i--;
}
diff --git a/java/org/apache/tomcat/util/net/SSLHostConfig.java
b/java/org/apache/tomcat/util/net/SSLHostConfig.java
index 3f47b1799f..fc4615f829 100644
--- a/java/org/apache/tomcat/util/net/SSLHostConfig.java
+++ b/java/org/apache/tomcat/util/net/SSLHostConfig.java
@@ -537,6 +537,7 @@ public class SSLHostConfig implements Serializable {
/**
* Set the enabled named groups.
+ *
* @param groupsString the case sensitive comma separated list of groups
*/
public void setGroups(String groupsString) {
diff --git a/java/org/apache/tomcat/util/net/SocketWrapperBase.java
b/java/org/apache/tomcat/util/net/SocketWrapperBase.java
index 214d984356..1b4f2eda8c 100644
--- a/java/org/apache/tomcat/util/net/SocketWrapperBase.java
+++ b/java/org/apache/tomcat/util/net/SocketWrapperBase.java
@@ -1361,7 +1361,7 @@ public abstract class SocketWrapperBase<E> {
try {
long timeoutExpiry = System.nanoTime() +
unit.toNanos(timeout);
long timeoutMillis = unit.toMillis(timeout);
- // Spurious wake-ups are possible. Keep waiting until
state changes or timeout expires.
+ // Spurious wake-ups are possible. Keep waiting until
state changes or timeout expires.
while (state.state == CompletionState.PENDING &&
timeoutMillis > 0) {
state.wait(unit.toMillis(timeout));
timeoutMillis = (timeoutExpiry -
System.nanoTime()) / 1_000_000;
diff --git a/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
b/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
index 767c381e59..3a0bfed0fe 100644
--- a/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
+++ b/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
@@ -204,8 +204,8 @@ public class TLSClientHelloExtractor {
if (log.isTraceEnabled()) {
log.trace("TLS Client Hello: " + clientRequestedCiphers + "
Names " + clientRequestedCipherNames +
" Protocols " + clientRequestedApplicationProtocols +
" sniValue " + sniValue +
- " clientRequestedProtocols " +
clientRequestedProtocols + " clientSupportedGroups " + clientSupportedGroups +
- " clientSignatureSchemes " + clientSignatureSchemes);
+ " clientRequestedProtocols " +
clientRequestedProtocols + " clientSupportedGroups " +
+ clientSupportedGroups + " clientSignatureSchemes " +
clientSignatureSchemes);
}
// Whatever happens, return the buffer to its original state
netInBuffer.limit(limit);
diff --git a/java/org/apache/tomcat/util/net/openssl/ciphers/Group.java
b/java/org/apache/tomcat/util/net/openssl/ciphers/Group.java
index 05fd55a769..2fe0abde19 100644
--- a/java/org/apache/tomcat/util/net/openssl/ciphers/Group.java
+++ b/java/org/apache/tomcat/util/net/openssl/ciphers/Group.java
@@ -21,8 +21,9 @@ import java.util.Map;
/**
* All the supported named groups for TLS 1.3.
- * @see <a
href="https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8";
>The supported groups
- * registry</a>
+ *
+ * @see <a
href="https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8";
>The supported
+ * groups registry</a>
*/
public enum Group {
diff --git
a/java/org/apache/tomcat/util/net/openssl/ciphers/SignatureScheme.java
b/java/org/apache/tomcat/util/net/openssl/ciphers/SignatureScheme.java
index e67bcdb21d..9e64672355 100644
--- a/java/org/apache/tomcat/util/net/openssl/ciphers/SignatureScheme.java
+++ b/java/org/apache/tomcat/util/net/openssl/ciphers/SignatureScheme.java
@@ -21,8 +21,9 @@ import java.util.Map;
/**
* All the signature schemes for TLS 1.3.
- * @see <a
href="https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-signaturescheme";
>The signature schemes
- * registry</a>
+ *
+ * @see <a
href="https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-signaturescheme";
>The
+ * signature schemes registry</a>
*/
public enum SignatureScheme {
diff --git a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java
b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java
index 229104378c..97b1ffc49d 100644
--- a/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java
+++ b/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java
@@ -1174,7 +1174,8 @@ public final class OpenSSLEngine extends SSLEngine
implements SSLUtil.ProtocolIn
X509_STORE_CTX_set_error(x509ctx,
X509_V_ERR_CERT_REVOKED());
} else if (ocspResponse == V_OCSP_CERTSTATUS_UNKNOWN()) {
errnum = X509_STORE_CTX_get_error(x509ctx);
- if (errnum != X509_V_ERR_UNABLE_TO_GET_CRL() &&
(errnum == X509_V_ERR_APPLICATION_VERIFICATION() || errnum != 0)) {
+ if (errnum != X509_V_ERR_UNABLE_TO_GET_CRL() &&
+ (errnum ==
X509_V_ERR_APPLICATION_VERIFICATION() || errnum != 0)) {
ok = 0;
}
}
@@ -1207,7 +1208,8 @@ public final class OpenSSLEngine extends SSLEngine
implements SSLUtil.ProtocolIn
if (openssl_h_Compatibility.OPENSSL &&
!openssl_h_Compatibility.OPENSSL3) {
issuer =
openssl_h_Compatibility.X509_STORE_CTX_get0_current_issuer(x509ctx);
} else {
- MemorySegment x509IssuerPointer =
localArena.allocateFrom(ValueLayout.ADDRESS, MemorySegment.NULL);
+ MemorySegment x509IssuerPointer =
+
localArena.allocateFrom(ValueLayout.ADDRESS, MemorySegment.NULL);
int res =
X509_STORE_CTX_get1_issuer(x509IssuerPointer, x509ctx, x509);
if (res > 0) {
issuer =
x509IssuerPointer.get(ValueLayout.ADDRESS, 0);
diff --git a/java/org/apache/tomcat/util/openssl/openssl_h.java
b/java/org/apache/tomcat/util/openssl/openssl_h.java
index 44edd4521d..8d29464821 100644
--- a/java/org/apache/tomcat/util/openssl/openssl_h.java
+++ b/java/org/apache/tomcat/util/openssl/openssl_h.java
@@ -3605,7 +3605,8 @@ public class openssl_h {
}
private static class X509_STORE_CTX_get1_issuer {
- public static final FunctionDescriptor DESC =
FunctionDescriptor.of(openssl_h.C_INT, openssl_h.C_POINTER,
openssl_h.C_POINTER, openssl_h.C_POINTER);
+ public static final FunctionDescriptor DESC =
+ FunctionDescriptor.of(openssl_h.C_INT, openssl_h.C_POINTER,
openssl_h.C_POINTER, openssl_h.C_POINTER);
public static final MemorySegment ADDR =
openssl_h.findOrThrow("X509_STORE_CTX_get1_issuer");
diff --git a/java/org/apache/tomcat/util/openssl/openssl_h_Macros.java
b/java/org/apache/tomcat/util/openssl/openssl_h_Macros.java
index 13106c484c..6ed564c676 100644
--- a/java/org/apache/tomcat/util/openssl/openssl_h_Macros.java
+++ b/java/org/apache/tomcat/util/openssl/openssl_h_Macros.java
@@ -448,8 +448,8 @@ public class openssl_h_Macros {
if (openssl_h_Compatibility.BORINGSSL) {
class Holder {
static final String NAME = "SSL_CTX_set1_groups_list";
- static final FunctionDescriptor DESC =
FunctionDescriptor.of(openssl_h.C_LONG, openssl_h.C_POINTER,
- openssl_h.C_POINTER);
+ static final FunctionDescriptor DESC =
+ FunctionDescriptor.of(openssl_h.C_LONG,
openssl_h.C_POINTER, openssl_h.C_POINTER);
static final MethodHandle MH =
Linker.nativeLinker().downcallHandle(openssl_h.findOrThrow(NAME), DESC);
}
var mh$ = Holder.MH;
diff --git a/java/org/apache/tomcat/websocket/Util.java
b/java/org/apache/tomcat/websocket/Util.java
index 5cf9a93f17..f8c10f6d9b 100644
--- a/java/org/apache/tomcat/websocket/Util.java
+++ b/java/org/apache/tomcat/websocket/Util.java
@@ -94,16 +94,16 @@ public class Util {
case 1002 -> CloseCodes.PROTOCOL_ERROR;
case 1003 -> CloseCodes.CANNOT_ACCEPT;
case 1004 ->
- // Should not be used in a close frame
- // return CloseCodes.RESERVED;
+ // Should not be used in a close frame
+ // return CloseCodes.RESERVED;
CloseCodes.PROTOCOL_ERROR;
case 1005 ->
- // Should not be used in a close frame
- // return CloseCodes.NO_STATUS_CODE;
+ // Should not be used in a close frame
+ // return CloseCodes.NO_STATUS_CODE;
CloseCodes.PROTOCOL_ERROR;
case 1006 ->
- // Should not be used in a close frame
- // return CloseCodes.CLOSED_ABNORMALLY;
+ // Should not be used in a close frame
+ // return CloseCodes.CLOSED_ABNORMALLY;
CloseCodes.PROTOCOL_ERROR;
case 1007 -> CloseCodes.NOT_CONSISTENT;
case 1008 -> CloseCodes.VIOLATED_POLICY;
@@ -111,16 +111,16 @@ public class Util {
case 1010 -> CloseCodes.NO_EXTENSION;
case 1011 -> CloseCodes.UNEXPECTED_CONDITION;
case 1012 ->
- // Not in RFC6455
- // return CloseCodes.SERVICE_RESTART;
+ // Not in RFC6455
+ // return CloseCodes.SERVICE_RESTART;
CloseCodes.PROTOCOL_ERROR;
case 1013 ->
- // Not in RFC6455
- // return CloseCodes.TRY_AGAIN_LATER;
+ // Not in RFC6455
+ // return CloseCodes.TRY_AGAIN_LATER;
CloseCodes.PROTOCOL_ERROR;
case 1015 ->
- // Should not be used in a close frame
- // return CloseCodes.TLS_HANDSHAKE_FAILURE;
+ // Should not be used in a close frame
+ // return CloseCodes.TLS_HANDSHAKE_FAILURE;
CloseCodes.PROTOCOL_ERROR;
default -> CloseCodes.PROTOCOL_ERROR;
};
diff --git a/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
b/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
index e35a234d4a..84dfb44a0d 100644
--- a/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
+++ b/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
@@ -72,9 +72,9 @@ public class UpgradeUtil {
*/
public static boolean isWebSocketUpgradeRequest(ServletRequest request,
ServletResponse response) {
- return ((request instanceof HttpServletRequest) &&
- (response instanceof HttpServletResponse) &&
headerContainsToken((HttpServletRequest) request,
- Constants.UPGRADE_HEADER_NAME,
Constants.UPGRADE_HEADER_VALUE) &&
+ return ((request instanceof HttpServletRequest) && (response
instanceof HttpServletResponse) &&
+ headerContainsToken((HttpServletRequest) request,
Constants.UPGRADE_HEADER_NAME,
+ Constants.UPGRADE_HEADER_VALUE) &&
Method.GET.equals(((HttpServletRequest) request).getMethod()));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
