stevearmstrong-dev commented on PR #924: URL: https://github.com/apache/tomcat/pull/924#issuecomment-3573171857
@markt-asf Thank you for the detailed review! You were absolutely right on all points. ## Changes Made I've updated the implementation to use `HttpServletRequest.logout()` and detect the authentication type via `request.getAuthType()`. ## Solution for Basic/Digest Auth Limitation Since true logout with HTTP Basic/Digest is impossible due to browser credential caching, I've switched both Manager and Host-Manager webapps to **Form-based authentication**. **Changes:** - Updated web.xml from `BASIC` to `FORM` authentication - Created branded login pages matching the Tomcat theme - Updated CSRF entry points This provides true logout capability - users see the login form again and can authenticate with different credentials. Let me know if you have concerns about changing the authentication method for these webapps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
