On 2026/03/06 18:25:50 [email protected] wrote:
> index c8fac1d531..1af899d8d2 100644
> --- 
> a/java/org/apache/catalina/tribes/membership/cloud/KubernetesMembershipProvider.java
> +++ 
> b/java/org/apache/catalina/tribes/membership/cloud/KubernetesMembershipProvider.java
> @@ -122,7 +125,12 @@ public class KubernetesMembershipProvider extends 
> CloudMembershipProvider {
>          namespace = URLEncoder.encode(namespace, StandardCharsets.UTF_8);
>          labels = labels == null ? null : URLEncoder.encode(labels, 
> StandardCharsets.UTF_8);
>  
> -        url = String.format("%s://%s:%s/api/%s/namespaces/%s/pods", 
> protocol, masterHost, masterPort, ver, namespace);
> +        String urlFormat = URL;
> +        if (masterHost != null && masterHost.indexOf(':') != -1) {

Why check for null here if used a bit later unconditionally?

> +            // [] must be used around raw IPv6
> +            urlFormat = IPV6_URL;
> +        }
> +        url = String.format(urlFormat, protocol, masterHost, masterPort, 
> ver, namespace);
>          if (labels != null && !labels.isEmpty()) {
>              url = url + "?labelSelector=" + labels;

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to