markt-asf commented on PR #958: URL: https://github.com/apache/tomcat/pull/958#issuecomment-4108949616
The first two test make no difference to the code coverage. Nor do they follow the pattern of the existing tests - which they should. The only reason there is a marginal increase in code coverage is `testEmptyParameterMap()` and, given that the implementation simply calls the same method on the delegated map, it adds little to no value. Implement the first two tests in a manner consistent with the existing tests (hint the PR should extend the existing tests - not add new ones) then there might be some value in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
