dsoumis commented on PR #969: URL: https://github.com/apache/tomcat/pull/969#issuecomment-4143837238
> I'm not a big fan of adding the dependency to the main TesterSupport class. Maybe move it somewhere else. Also usually we use static certificates but of course the strategy doesn't scale indefinitely. I was thinking that would be beneficial if we had a certificate generation method programmatically in the main helper class. The reason I didn't use a static certificate for the test, was exactly this; the ability to create one programmatically through BouncyCastle and avoid adding extra resources to the repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
