This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 63b113395e Refactor. Simplify. escapeAndAppend() includes null handling
63b113395e is described below
commit 63b113395e05dba2242685163240218f5647d4f2
Author: Mark Thomas <[email protected]>
AuthorDate: Wed Apr 1 11:06:29 2026 +0100
Refactor. Simplify. escapeAndAppend() includes null handling
---
java/org/apache/catalina/valves/AbstractAccessLogValve.java | 7 +------
webapps/docs/changelog.xml | 8 ++++++++
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/java/org/apache/catalina/valves/AbstractAccessLogValve.java
b/java/org/apache/catalina/valves/AbstractAccessLogValve.java
index 635e4c0437..e5f14f0424 100644
--- a/java/org/apache/catalina/valves/AbstractAccessLogValve.java
+++ b/java/org/apache/catalina/valves/AbstractAccessLogValve.java
@@ -926,12 +926,7 @@ public abstract class AbstractAccessLogValve extends
ValveBase implements Access
@Override
public void addElement(CharArrayWriter buf, Date date, Request
request, Response response, long time) {
if (request != null) {
- String value = request.getRemoteUser();
- if (value != null) {
- escapeAndAppend(value, buf);
- } else {
- buf.append('-');
- }
+ escapeAndAppend(request.getRemoteUser(), buf);
} else {
buf.append('-');
}
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index f97263ea6a..42c21e9fc9 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -105,6 +105,14 @@
issues do not "pop up" wrt. others).
-->
<section name="Tomcat 9.0.118 (remm)" rtext="in development">
+ <subsection name="Catalina">
+ <changelog>
+ <scode>
+ Refactor generation of the remote user element in the access log to
+ remove unnecessary code. (markt)
+ </scode>
+ </changelog>
+ </subsection>
</section>
<section name="Tomcat 9.0.117 (remm)" rtext="release in progress">
<subsection name="Catalina">
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
