On Sat, May 16, 2026 at 2:01 PM Mark Thomas <[email protected]> wrote:
>
> 16 May 2026 12:52:12 Rémy Maucherat <[email protected]>:
>
> > On Sat, May 16, 2026 at 8:42 AM <[email protected]> wrote:
> >>
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> markt-asf pushed a commit to branch 9.0.x
> >> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/9.0.x by this push:
> >> new 4c204d6a91 Unregister the old host, not the new one.
> >> 4c204d6a91 is described below
> >>
> >> commit 4c204d6a91b50b8ca5cbe81d74513cbecc6e0f3e
> >> Author: Mark Thomas <[email protected]>
> >> AuthorDate: Sat May 16 07:38:47 2026 +0100
> >>
> >> Unregister the old host, not the new one.
> >
> > Oops. Next time I'll ask the LLM to do the simple fixes. Or most
> > likely I'll try to pay more attention ! Sorry, and thanks !
> > These defects were found by OpenCode, I'll do package by package
> > reviews.
>
> I think this error was a very old one of mine.
Line 502 is my fault, the other one is similar so I mixed it up. The
LLM did not catch this one, it was not in the report, but IMO it
should have had.
Rémy
> Mark
>
> >
> > Rémy
> >
> >> ---
> >> java/org/apache/tomcat/util/net/AbstractEndpoint.java | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/java/org/apache/tomcat/util/net/AbstractEndpoint.java
> >> b/java/org/apache/tomcat/util/net/AbstractEndpoint.java
> >> index 11a7a293d0..c7ca88920a 100644
> >> --- a/java/org/apache/tomcat/util/net/AbstractEndpoint.java
> >> +++ b/java/org/apache/tomcat/util/net/AbstractEndpoint.java
> >> @@ -407,7 +407,7 @@ public abstract class AbstractEndpoint<S, U> {
> >> setDefaultSslHostConfig(sslHostConfig);
> >> }
> >> if (previous != null) {
> >> - unregisterJmx(sslHostConfig);
> >> + unregisterJmx(previous);
> >> }
> >> registerJmx(sslHostConfig);
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [email protected]
> >> For additional commands, e-mail: [email protected]
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
